Skip to content

Implement tick() for RISC-V#859

Merged
mjp41 merged 1 commit into
microsoft:mainfrom
Xeonacid:fix-riscv-tick
Jul 7, 2026
Merged

Implement tick() for RISC-V#859
mjp41 merged 1 commit into
microsoft:mainfrom
Xeonacid:fix-riscv-tick

Conversation

@Xeonacid

Copy link
Copy Markdown
Contributor

RISC-V builds currently fail when code instantiates Aal::tick() if the compiler does not provide __builtin_readcyclecounter(). The generic AAL falls back to Arch::tick(), but AAL_RISCV has no implementation.

@mjp41 mjp41 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would you be able to address the clangformat issue please. Thanks

@Xeonacid

Xeonacid commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

LGTM, would you be able to address the clangformat issue please. Thanks

Oops, I didn't notice that. Updated. Thanks for the review!

RISC-V builds currently fail when code instantiates Aal::tick() if the compiler does not provide __builtin_readcyclecounter(). The generic AAL falls back to Arch::tick(), but AAL_RISCV has no implementation.
@mjp41 mjp41 force-pushed the fix-riscv-tick branch from a029b4f to ad8b035 Compare July 7, 2026 11:04
@mjp41 mjp41 merged commit 481b648 into microsoft:main Jul 7, 2026
198 checks passed
@Xeonacid Xeonacid deleted the fix-riscv-tick branch July 8, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants